Skip to content

feat: #106 Improve signIn error handling #107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ianpaschal merged 1 commit into from
Jun 30, 2025
Merged

feat: #106 Improve signIn error handling #107

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/pages/AuthPage/components/SignInForm/SignInForm.schema.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import { z } from 'zod';

export const signInFormSchema = z.object({
email: z.string().min(1, 'Please enter your email.').transform((val) => val.trim().toLowerCase()),
email: z.string().email('Please enter your email.').transform((val) => val.trim().toLowerCase()),
password: z.string().min(1, 'Please enter your password.').transform((val) => val.trim()),
});

Expand Down
16 changes: 15 additions & 1 deletion src/services/auth/useSignIn.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,19 @@ type SignInInput = {
password: string;
};

// eslint-disable-next-line @typescript-eslint/no-explicit-any
function mapConvexAuthError(error: any): string {
if (!error?.message) {
return 'An unexpected error occurred. Please try again.';
}

if (error.message.includes('InvalidAccountId')) {
return 'Your email or password is incorrect.';
}

return 'Sign-in failed. Please check your details and try again.';
}

export const useSignIn = () => {
const { signIn } = useAuthActions();
const navigate = useNavigate();
Expand Down Expand Up @@ -47,8 +60,9 @@ export const useSignIn = () => {
flow: 'signIn',
}).catch((error) => {
setLoading(false);
const description = mapConvexAuthError(error);
console.error(error);
toast.error('Error', { description: error.message });
toast.error('Error', { description: description });
});
},
loading,
Expand Down