Update EvModelWrapper.scala #1592
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
updated changes from pRated to sRated #1250
danielfeismann
requested changes
Dec 11, 2025
Member
danielfeismann
left a comment
danielfeismann
left a comment
There was a problem hiding this comment.
Thanks for handling this, some things need to be adapted. Please also do not forget the changelog
Comment on lines
37
to
41
|
|
||
| lazy val pRatedAc: Power = original.getPRatedAC.toSquants | ||
| // lazy val pRatedAc: Power = original.getPRatedAC.toSquants | ||
| lazy val sRatedAc: Power = original.getSRatedAC.toSquants | ||
| // from cosphi() rated from simonaAPI EVModel | ||
| lazy val cosPhiRated: Double = original.getCosPhiRated |
Member
There was a problem hiding this comment.
Please remove the comments here.
src/main/scala/edu/ie3/simona/model/participant/evcs/EvcsChargingProperties.scala
Outdated
Show resolved
Hide resolved
Resolves #1250 changelog for reactive power updates in Evcs Model
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
updated changes from pRated to sRated #1250
resolves #1250
Related to SimonAPI Issue 259 [https://github.com/ie3-institute/simonaAPI/issues/259]