Skip to content

Update EvModelWrapper.scala #1592

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kkarthik11 wants to merge 5 commits into
base: dev
Choose a base branch
from
Open

Update EvModelWrapper.scala #1592

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
918a227
Update EvModelWrapper.scala
kkarthik11 Nov 13, 2025
b28d809
Resolves #1250 updated API version in build.gradle file
Dec 11, 2025
55797cd
Resolves #1250 updated errors in EVModelWrapper and EvcsChargingprope…
Dec 11, 2025
8ba9dfc
Resolves #1250 updated as per comments 12122025
Dec 12, 2025
02c311f
Update CHANGELOG.md
kkarthik11 Dec 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
- Refactored method to handle feed in within `ThermalGrid` [#1554](https://github.com/ie3-institute/simona/issues/1554)
- Generalize `WeatherSeriesData` to `SecondarySeriesData` [#1584](https://github.com/ie3-institute/simona/issues/1584)
- Enhance `EnergyPrice` squants [#1583](https://github.com/ie3-institute/simona/issues/1583)
- Chnaged reactive power of EVs in EvcsModel according to simonaAPI [#1250](https://github.com/ie3-institute/simona/issues/1250)

### Fixed
- Fixes in Documentation, ScalaDocs, Code Style and more [#1397](https://github.com/ie3-institute/simona/issues/1397)
Expand Down
2 changes: 1 addition & 1 deletion build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ dependencies {
exclude group: 'edu.ie3'
}

implementation('com.github.ie3-institute:simonaAPI:0.11.0') {
implementation('com.github.ie3-institute:simonaAPI:0.12.0') {
exclude group: 'org.apache.logging.log4j'
exclude group: 'org.slf4j'
/* Exclude our own nested dependencies */
Expand Down
3 changes: 2 additions & 1 deletion src/main/scala/edu/ie3/simona/model/participant/evcs/EvModelWrapper.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,8 @@ final case class EvModelWrapper(
def uuid: UUID = original.getUuid
def id: String = original.getId

lazy val pRatedAc: Power = original.getPRatedAC.toSquants
lazy val sRatedAc: Power = original.getSRatedAC.toSquants
lazy val cosPhiRated: Double = original.getCosPhiRated
lazy val pRatedDc: Power = original.getPRatedDC.toSquants
lazy val eStorage: Energy = original.getEStorage.toSquants

Expand Down
2 changes: 1 addition & 1 deletion src/main/scala/edu/ie3/simona/model/participant/evcs/EvcsChargingProperties.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ trait EvcsChargingProperties {
): Power = {
val evPower = currentType match {
case ElectricCurrentType.AC =>
ev.pRatedAc
ev.sRatedAc * ev.cosPhiRated
case ElectricCurrentType.DC =>
ev.pRatedDc
}
Expand Down