Skip to content
This repository was archived by the owner on Aug 26, 2022. It is now read-only.

Fix/codeql#162

Open
brenordr wants to merge 2 commits intodevelopfrom
fix/codeql
Open

Fix/codeql#162
brenordr wants to merge 2 commits intodevelopfrom
fix/codeql

Conversation

@brenordr
Copy link
Copy Markdown
Member

@brenordr brenordr commented Nov 12, 2021

Description

Kind:

Add security fixes for #160 and #159

Section:

authsvc and insprd have been updated in this PR

for authsvc the bitsize was lift to 2048 bits

for insprd added a check to the port size to be a guaranteed TCP / UDP port

Summary:

Changelog

List the main points of change

Pay attention to

Important parts of the code that require special attention

Need to add changelog before merge :)

TCP / UDP ports are Uint16
and 0 is reserved
Other ports are reserved too, but checking for this range is the minimum
@brenordr brenordr requested a review from a team as a code owner November 12, 2021 01:47
@codecov
Copy link
Copy Markdown

codecov Bot commented Nov 12, 2021

Codecov Report

Merging #162 (31f3103) into develop (964f017) will increase coverage by 1.19%.
The diff coverage is 88.34%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #162      +/-   ##
===========================================
+ Coverage    75.05%   76.25%   +1.19%     
===========================================
  Files          116      117       +1     
  Lines         6538     6880     +342     
===========================================
+ Hits          4907     5246     +339     
+ Misses        1391     1384       -7     
- Partials       240      250      +10     
Flag Coverage Δ
unittests 76.25% <88.34%> (+1.19%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cmd/insprctl/cli/apply_dapp.go 52.00% <0.00%> (-3.32%) ⬇️
pkg/api/handlers/token_handler.go 5.63% <0.00%> (+0.15%) ⬆️
pkg/controller/client/auth.go 100.00% <ø> (ø)
pkg/utils/string_slice.go 70.21% <20.00%> (-3.60%) ⬇️
pkg/sidecars/server/handlers.go 50.60% <66.66%> (-6.55%) ⬇️
pkg/meta/utils/format.go 73.52% <67.27%> (+6.86%) ⬆️
pkg/rest/middleware.go 95.50% <73.33%> (-4.50%) ⬇️
cmd/insprd/operators/nodes/converter.go 72.42% <82.14%> (+0.09%) ⬆️
pkg/sidecars/lbsidecar/handlers.go 81.28% <90.41%> (+4.48%) ⬆️
cmd/sidecars/kafka/client/reader.go 81.65% <92.30%> (+3.33%) ⬆️
... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 870bb13...31f3103. Read the comment docs.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant