Skip to content
This repository was archived by the owner on Aug 26, 2022. It is now read-only.

Fix/codeql #162

Open
brenordr wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Fix/codeql #162

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
44d0d48
fix(authsvc): update key length to 2048 bits
brenordr Nov 12, 2021
31f3103
fix(insprd): check if sidecar port is valid
brenordr Nov 12, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions cmd/authsvc/authsec/main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,6 @@ import (
var clientSet kubernetes.Interface
var logger *zap.Logger

const bitSize = 512 // min size for encoding your payload

func generatePassword() string {
chars := []rune("ABCDEFGHIJKLMNOPQRSTUVWXYZ" +
"abcdefghijklmnopqrstuvwxyz" +
Expand Down Expand Up @@ -57,7 +55,7 @@ func initKube() error {

func generatePrivateKey() (*rsa.PrivateKey, error) {
// Private Key generation
privateKey, err := rsa.GenerateKey(rand.Reader, bitSize)
privateKey, err := rsa.GenerateKey(rand.Reader, 2048)
if err != nil {
return nil, err
}
Expand Down
9 changes: 8 additions & 1 deletion cmd/insprd/operators/nodes/converter.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ package nodes

import (
"fmt"
"math"
"os"
"strconv"
"strings"
Expand All @@ -26,7 +27,13 @@ func (no *NodeOperator) dappToService(app *meta.App) *kubeService {
logger.Info("creating kubernetes service")

temp, _ := strconv.Atoi(os.Getenv("INSPR_LBSIDECAR_READ_PORT"))
lbsidecarPort = int32(temp)
if temp > 0 && temp < math.MaxUint16 {
lbsidecarPort = int32(temp)
} else {
// ref http://www.faqs.org/rfcs/rfc793.html
panic("invalid port number. the highest valid TCP / UDP port number is 65535 and the lowest is 1")
}

appID := toAppID(app)
appDeployName := toDeploymentName(app)
appLabels := map[string]string{"inspr-app": appID}
Expand Down