Issue-174: Mock iota client in integration tests

docs/iota-java/isPromotable.md

@@ -16,14 +16,7 @@ Checks if a transaction hash is promotable
 | boolean  | `true` if it is, otherwise `false` |
 
 ## Exceptions
-| Exceptions     | Description |
-|:---------------|:--------|
-| [ArgumentException](https://github.com/iotaledger/iota-java/blob/master/jota/src/main/java/org/iota/jota/error/ArgumentException.java) | when we can't get the consistency of this transaction |
-
-## Related APIs (link to other product documentation)
-| API     | Description |
-|:---------------|:--------|
-| [checkConsistency(String...)](https://github.com/iotaledger/iota-java/blob/master/jota/src/main/java/org/iota/jota/IotaAPICore.java#L628) | Checks the consistency of the subtangle formed by the provided tails. |
+None
 
  ## Example
 

docs/iota-java/promoteTransaction.md

@@ -47,7 +47,6 @@ List<[Transaction](https://github.com/iotaledger/iota-java/blob/master/jota/src/
 ## Related APIs (link to other product documentation)
 | API     | Description |
 |:---------------|:--------|
-| [checkConsistency(String...)](https://github.com/iotaledger/iota-java/blob/master/jota/src/main/java/org/iota/jota/IotaAPICore.java#L628) | Checks the consistency of the subtangle formed by the provided tails. |
 | [getTransactionsToApprove(Integer, String)](https://github.com/iotaledger/iota-java/blob/master/jota/src/main/java/org/iota/jota/IotaAPICore.java#L423) | Tip selection which returns `trunkTransaction` and `branchTransaction`. The input value `depth` determines how many milestones to go back for finding the transactions to approve. The higher your `depth` value, the more work you have to do as you are confirming more transactions. If the `depth` is too large (usually above 15, it depends on the node's configuration) an error will be returned. The `reference` is an optional hash of a transaction you want to approve. If it can't be found at the specified `depth` then an error will be returned. |
 | [attachToTangle(String, String, Integer, String...)](https://github.com/iotaledger/iota-java/blob/master/jota/src/main/java/org/iota/jota/IotaAPICore.java#L673) |  Prepares the specified transactions (trytes) for attachment to the Tangle by doing Proof of Work. You need to supply `branchTransaction` as well as `trunkTransaction`. These are the tips which you're going to validate and reference with this transaction. These are obtainable by the `getTransactionsToApprove` API call. 
   The returned value is a different set of tryte values which you can input into `broadcastTransactions` and `storeTransactions`. 

jota/src/main/java/org/iota/jota/IotaAPICommand.java

@@ -21,7 +21,6 @@ public enum IotaAPICommand {
     INTERRUPT_ATTACHING_TO_TANGLE("interruptAttachingToTangle"),
     BROADCAST_TRANSACTIONS("broadcastTransactions"),
     STORE_TRANSACTIONS("storeTransactions"),
-    CHECK_CONSISTENCY("checkConsistency"),
     WERE_ADDRESSES_SPENT_FROM("wereAddressesSpentFrom"),
     CUSTOM_IXI("IXI");
 

jota/src/main/java/org/iota/jota/IotaAPICore.java

@@ -1,36 +1,67 @@
 package org.iota.jota;
 
-import static org.iota.jota.utils.Constants.INVALID_ADDRESSES_INPUT_ERROR;
-import static org.iota.jota.utils.Constants.INVALID_APPROVE_DEPTH_ERROR;
-import static org.iota.jota.utils.Constants.INVALID_ATTACHED_TRYTES_INPUT_ERROR;
-import static org.iota.jota.utils.Constants.INVALID_BUNDLE_HASH_ERROR;
-import static org.iota.jota.utils.Constants.INVALID_HASHES_INPUT_ERROR;
-import static org.iota.jota.utils.Constants.INVALID_TAG_INPUT_ERROR;
-import static org.iota.jota.utils.Constants.INVALID_THRESHOLD_ERROR;
-import static org.iota.jota.utils.Constants.INVALID_TRYTES_INPUT_ERROR;
-
 import org.apache.commons.lang3.ArrayUtils;
 import org.iota.jota.connection.Connection;
-import org.iota.jota.dto.request.*;
-import org.iota.jota.dto.response.*;
+import org.iota.jota.dto.request.IotaAttachToTangleRequest;
+import org.iota.jota.dto.request.IotaBroadcastTransactionRequest;
+import org.iota.jota.dto.request.IotaCommandRequest;
+import org.iota.jota.dto.request.IotaCustomRequest;
+import org.iota.jota.dto.request.IotaFindTransactionsRequest;
+import org.iota.jota.dto.request.IotaGetBalancesRequest;
+import org.iota.jota.dto.request.IotaGetInclusionStateRequest;
+import org.iota.jota.dto.request.IotaGetTransactionsToApproveRequest;
+import org.iota.jota.dto.request.IotaGetTrytesRequest;
+import org.iota.jota.dto.request.IotaNeighborsRequest;
+import org.iota.jota.dto.request.IotaStoreTransactionsRequest;
+import org.iota.jota.dto.request.IotaWereAddressesSpentFromRequest;
+import org.iota.jota.dto.response.AddNeighborsResponse;
+import org.iota.jota.dto.response.BroadcastTransactionsResponse;
+import org.iota.jota.dto.response.FindTransactionResponse;
+import org.iota.jota.dto.response.GetAttachToTangleResponse;
+import org.iota.jota.dto.response.GetBalancesResponse;
+import org.iota.jota.dto.response.GetInclusionStateResponse;
+import org.iota.jota.dto.response.GetNeighborsResponse;
+import org.iota.jota.dto.response.GetNodeAPIConfigurationResponse;
+import org.iota.jota.dto.response.GetNodeInfoResponse;
+import org.iota.jota.dto.response.GetTipsResponse;
+import org.iota.jota.dto.response.GetTransactionsToApproveResponse;
+import org.iota.jota.dto.response.GetTrytesResponse;
+import org.iota.jota.dto.response.InterruptAttachingToTangleResponse;
+import org.iota.jota.dto.response.IotaCustomResponse;
+import org.iota.jota.dto.response.RemoveNeighborsResponse;
+import org.iota.jota.dto.response.StoreTransactionsResponse;
+import org.iota.jota.dto.response.WereAddressesSpentFromResponse;
 import org.iota.jota.error.ArgumentException;
 import org.iota.jota.model.Transaction;
 import org.iota.jota.pow.ICurl;
-import org.iota.jota.pow.SpongeFactory;
 import org.iota.jota.utils.Checksum;
 import org.iota.jota.utils.InputValidator;
 import org.iota.mddoclet.Document;
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 
-import java.util.*;
+import java.util.ArrayList;
+import java.util.Arrays;
+import java.util.Collections;
+import java.util.List;
+import java.util.Map;
+import java.util.Random;
+
+import static org.iota.jota.utils.Constants.INVALID_ADDRESSES_INPUT_ERROR;
+import static org.iota.jota.utils.Constants.INVALID_APPROVE_DEPTH_ERROR;
+import static org.iota.jota.utils.Constants.INVALID_ATTACHED_TRYTES_INPUT_ERROR;
+import static org.iota.jota.utils.Constants.INVALID_BUNDLE_HASH_ERROR;
+import static org.iota.jota.utils.Constants.INVALID_HASHES_INPUT_ERROR;
+import static org.iota.jota.utils.Constants.INVALID_TAG_INPUT_ERROR;
+import static org.iota.jota.utils.Constants.INVALID_THRESHOLD_ERROR;
+import static org.iota.jota.utils.Constants.INVALID_TRYTES_INPUT_ERROR;
 
 /**
  * This class provides access to the Iota core API
  * Handles direct methods with the connected node(s), and does basic verification
  */
 public class IotaAPICore {
-    private static final Logger log = LoggerFactory.getLogger(IotaAPICore.class);
+    private static final Logger LOGGER = LoggerFactory.getLogger(IotaAPICore.class);
 
     private ApiOptions options;
 
@@ -39,8 +70,8 @@ public class IotaAPICore {
     protected IotaAPICore(ApiOptions options) {
         this.options = options;
 
-        for (Connection c : options.getNodes()) {
-            addNode(c);
+        for (Connection connection : options.getNodes()) {
+            addNode(connection);
         }
     }
 
@@ -70,21 +101,21 @@ public boolean addNode(Connection n) {
             synchronized (nodes) {
                 for (Connection c : nodes) {
                     if (c.equals(n)) {
-                        log.warn("Tried to add a node we allready have: " + n);
+                        LOGGER.warn("Tried to add a node we allready have: " + n);
                         return true;
                     }
                 }
 
                 boolean started = n.start();
                 if (started) {
                     nodes.add(n);
-                    log.debug("Added node: " + n.toString());
+                    LOGGER.debug("Added node: " + n.toString());
                 }
 
                 return started;
             }
         } catch (Exception e) {
-            log.warn("Failed to add node connection to pool due to \"" + e.getMessage() + "\"");
+            LOGGER.warn("Failed to add node connection to pool due to \"" + e.getMessage() + "\"");
             return false;
         }
     }
@@ -386,7 +417,7 @@ public GetInclusionStateResponse getInclusionStates(String... transactions) thro
     /**
      * Returns the raw transaction data (trytes) of a specific transaction.
      * These trytes can then be easily converted into the actual transaction object.
-     * You can use {@link Transaction#Transaction(String)} for conversion to an object.
+     * You can use {@link Transaction.Builder#buildWithTrytes(String)} for conversion to an object.
      *
      * @param hashes The transaction hashes you want to get trytes from.
      * @return {@link GetTrytesResponse}
@@ -617,22 +648,6 @@ public WereAddressesSpentFromResponse wereAddressesSpentFrom(String... addresses
         return getNodeFor(IotaAPICommand.WERE_ADDRESSES_SPENT_FROM).wereAddressesSpentFrom(IotaWereAddressesSpentFromRequest.create(addressesWithoutChecksum));
     }
 
-    /**
-     * Checks the consistency of the subtangle formed by the provided tails.
-     *
-     * @param tails The tails describing the subtangle.
-     * @return {@link CheckConsistencyResponse}
-     * @throws ArgumentException when a tail hash is invalid
-     */
-    @Document
-    public CheckConsistencyResponse checkConsistency(String... tails) throws ArgumentException {
-        if (!InputValidator.isArrayOfHashes(tails)) {
-            throw new ArgumentException(INVALID_HASHES_INPUT_ERROR);
-        }
-
-        return getNodeFor(IotaAPICommand.CHECK_CONSISTENCY).checkConsistency(IotaCheckConsistencyRequest.create(tails));
-    }
-
     /**
      * <p>
      * Prepares the specified transactions (trytes) for attachment to the Tangle by doing Proof of Work.
@@ -733,7 +748,7 @@ public GetAttachToTangleResponse attachToTangle(String trunkTransaction, String
     public GetAttachToTangleResponse attachToTangleLocalPow(String trunkTransaction, String branchTransaction,
                                                             Integer minWeightMagnitude, IotaPoW pow, String... trytes) {
         if (pow == null) {
-            log.warn("Called local POW without POW defined, switching to remote POW");
+            LOGGER.warn("Called local POW without POW defined, switching to remote POW");
             return attachToTangle(trunkTransaction, branchTransaction, minWeightMagnitude, trytes);
         }
 
@@ -754,20 +769,20 @@ public GetAttachToTangleResponse attachToTangleLocalPow(String trunkTransaction,
 
         try {
             for (int i = 0; i < resultTrytes.length; i++) {
-                Transaction txn = new Transaction(trytes[i]);
-                txn.setTrunkTransaction(previousTransaction == null ? trunkTransaction : previousTransaction);
-                txn.setBranchTransaction(previousTransaction == null ? branchTransaction : trunkTransaction);
+                Transaction transaction = new Transaction.Builder().buildWithTrytes(trytes[i]);
+                transaction.setTrunkTransaction(previousTransaction == null ? trunkTransaction : previousTransaction);
+                transaction.setBranchTransaction(previousTransaction == null ? branchTransaction : trunkTransaction);
 
-                if (txn.getTag().isEmpty() || txn.getTag().matches("9*")) {
-                    txn.setTag(txn.getObsoleteTag());
+                if (transaction.getTag().isEmpty() || transaction.getTag().matches("9*")) {
+                    transaction.setTag(transaction.getObsoleteTag());
                 }
 
-                txn.setAttachmentTimestamp(System.currentTimeMillis());
-                txn.setAttachmentTimestampLowerBound(0);
-                txn.setAttachmentTimestampUpperBound(3_812_798_742_493L);
+                transaction.setAttachmentTimestamp(System.currentTimeMillis());
+                transaction.setAttachmentTimestampLowerBound(0);
+                transaction.setAttachmentTimestampUpperBound(3_812_798_742_493L);
 
-                resultTrytes[i] = pow.performPoW(txn.toTrytes(), minWeightMagnitude);
-                previousTransaction = new Transaction(resultTrytes[i], SpongeFactory.create(SpongeFactory.Mode.CURL_P81)).getHash();
+                resultTrytes[i] = pow.performPoW(transaction.toTrytes(), minWeightMagnitude);
+                previousTransaction = new Transaction.Builder().buildWithTrytes(resultTrytes[i]).getHash();
             }
             Collections.reverse(Arrays.asList(resultTrytes));
         } catch (Exception e) {