-
Notifications
You must be signed in to change notification settings - Fork 2.3k
Simplifies cross platform installation setup.py #3294
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplifies cross platform installation setup.py #3294
Conversation
60c3c4c
to
176ae7d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall.
Mostly wondering why are we enforcing torch via the install script and not the pyproject.toml file. I think back then the motivation was to force install a specific torch version (different from one shipped with IsaacSim). But is this still needed?
I think it'd still be needed if we want to continue support for 4.5. We might also need to do something like this eventually when Isaac Sim removes the pytorch dependency to avoid issues on windows. |
Description
This PR
makes sure(skip if already satisfy, else install) the right torch is installed before and after pip installing isaaclab packages as sometime(rare case) due to flaky setup.py and unknown library dependencies changes pytorch version gets overriden.
only install pink and retargeters in linux x86 or amd64 machines
Type of change
Screenshots
Please attach before and after screenshots of the change if applicable.
Checklist
pre-commit
checks with./isaaclab.sh --format
config/extension.toml
fileCONTRIBUTORS.md
or my name already exists there