feat: support real-Cartesian Boozer chartmaps#261
Merged
krystophny merged 1 commit intomainfrom Mar 28, 2026
Merged
Conversation
This was referenced Mar 28, 2026
Member
Author
|
@Rykath this is the libneo dependency for the stacked SIMPLE Boozer-chartmap series. The SIMPLE side is now split as PRs 329, 330, 331, and 327; this libneo PR is the generalized real-Cartesian Boozer chartmap piece underneath them. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Support real-Cartesian Boozer chartmaps in libneo by treating
zeta_convention='boozer'as a genuine chart parameter instead of requiringatan2(y,x)=zeta.This keeps the current fast
cylandvmecpaths intact while enabling the generalized chartmap path needed for GVEC-style Boozer files where the toroidal parameter is not the cylindrical angle.What changed
zeta_convention='boozer'in chartmap validation and metadataatan2(y,x)=zetacontract only forcylandvmecboozerfrom_cart(...)forboozerSIMPLE integration
This is the libneo dependency for the stacked SIMPLE series ending in PR 327:
Verification
Result:
100% tests passed, 0 tests failed out of 4Review
Primary libneo/chartmap review: @krystophny
GVEC-use-case review: @Rykath