Open
Conversation
Contributor
|
How is this different from #23? |
Contributor
|
Also can you provide a picture of what this looks like please? |
Author
|
Sorry for the late answer, @caleb15. I recorded this short preview so you have an idea how it looks
|
Contributor
|
Interesting. Are saved queries grouped by each model (queries only appear
on page they are on) or are all queries visible globally? For companies
with a lot of users the amount of saved queries could get quite large.
…On Fri, May 31, 2019, 5:25 AM Vladislav ***@***.***> wrote:
Sorry for the late answer, @caleb15 <https://github.com/caleb15>. I
recorded this short preview so you have an idea how it looks
[image: out]
<https://user-images.githubusercontent.com/1459916/58705137-f2110900-83b6-11e9-9329-794e99a9b9c1.gif>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#35?email_source=notifications&email_token=ALCZY6ILTVIOOJUEW4FGLLDPYEKMHA5CNFSM4GWUGR22YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODWVCM3Y#issuecomment-497690223>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ALCZY6LB3Q36XX7CC5LJGR3PYEKMHANCNFSM4GWUGR2Q>
.
|
Author
|
Yes, saved queries are grouped by model and displayed only on corresponding pages |
Contributor
|
well from a user perspective looks good to me. And you have tests too. Hopefully someone can give you a code review soon. |
|
Kudos, SonarCloud Quality Gate passed!
|
|
Can we solve the merge request soon as possible? This feature is a need for our company. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here is my implemetation for the #1.
Since indicated that DjangoQL can be used separately from the administration interface, I decided to put the urls separately from DjangoQLSearchMixin. JS is also structured accordingly.
I will be glad to hear criticism and suggestions.
Tested with Django 1.8/2.1, Latest Chrome and Mozilla Firefox. I suppose it’s not difficult to support IE9+ after some changes