removing destroyed context menu's from the DOM#1
Open
rovolution wants to merge 2 commits intojakiestfu:masterfrom
Open
removing destroyed context menu's from the DOM#1rovolution wants to merge 2 commits intojakiestfu:masterfrom
rovolution wants to merge 2 commits intojakiestfu:masterfrom
Conversation
Author
|
hey @jakiestfu, did you ever get a chance to check this out? Thanks! |
|
+1 on this pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
hey jakiestfu,
Thanks for this awesome plugin btw! Hands down the best bootstrap context menu plugin I've worked with.
This pull request is to fix an issue I had with it in one of the applications I am working on.
In my use case, I have a graph consisting of nodes and edges, where each node has its own context menu. A user is constantly loading different graphs, which requires the frequent removal/addition of nodes.
I noticed that whenever I destroyed a context menu on a node, it was not actually removing it from the DOM. Consequently my DOM would become populated with these 'ghost' context menus. This fix removes the context menu from the DOM when the destroy call is made.
Let me know what you think and if I should change anything.
Thanks!