Skip to content

getRelativeTo gets confused when there are multiple occurences of the same separator in the string#10

Merged
jarradseers merged 2 commits intojarradseers:developfrom
PauloMigAlmeida:develop
Jun 18, 2017
Merged

getRelativeTo gets confused when there are multiple occurences of the same separator in the string#10
jarradseers merged 2 commits intojarradseers:developfrom
PauloMigAlmeida:develop

Conversation

@PauloMigAlmeida
Copy link
Copy Markdown
Contributor

This PR address the issue #9

Let me know if you need any information from me to get this PR approved.

Best regards,

Paulo Almeida

@PauloMigAlmeida PauloMigAlmeida changed the title getRelativeTo gets confused when there multiple occurences of the same separator in the string getRelativeTo gets confused when there are multiple occurences of the same separator in the string Dec 17, 2016
@PauloMigAlmeida
Copy link
Copy Markdown
Contributor Author

ping @jarradseers

@felipeplets
Copy link
Copy Markdown

@PauloMigAlmeida as I see now you solved an issue related to one I've solved #16
Both solve different problems changing the same part of the code so I think we can try to solve both with one unique implementation.
My current solution would be to not use the full file path but relative path, so in this case you would always get the last part of the string solving your issue and if using my code it would also solve my issue.
What do you think?

@PauloMigAlmeida
Copy link
Copy Markdown
Contributor Author

Hi @felipeplets,

Thanks for you message, I appreciate your time taking a look at it.

As much as I like you idea, I tend not to believe this will be a good investment of our time. Not because isn't worthwhile, but because the owner of this repository hasn't even commented on any of the PRs proposed in the last 6 months.

If he starts looking at the issues/PRs again, I will be more than happy to do this single implementation with you @felipeplets.

Best regards,

@felipeplets
Copy link
Copy Markdown

Hello @PauloMigAlmeida,

I've sent #17 to @jarradseers, if he does no answer in the next days I believe we can fork it and start a new project.

Are you using express-load or consign in your projects?

All the best,
Felipe

@jarradseers jarradseers merged commit 08a32e9 into jarradseers:develop Jun 18, 2017
@felipeplets felipeplets mentioned this pull request Jun 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants