Open
Conversation
_getRelativeTo was not considering only the first occurrence of the cwd option, with regex I fixed that.
*My use case:*
I have the location app/controller/appUser.js
Loading it with consign as follows:
```
consign({cwd: 'app'}).include('controller');
```
This would cause the _getRelativeTo to return ['/Users/myuser/project/','/controller/'] and thus to not load the controller.
Author
|
This is a complement to #10 but now it is conflicting with the other implementation. To fix both issues my idea is to use path.relative from NodeJS to complement this fix and have no other issue with splitting names on consign. If anyone has another idea please let me know. Otherwise I intend to implement it during the week. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
_getRelativeTo was not considering only the first occurrence of the cwd option, with regex I fixed that.
My use case:
I have the location app/controller/appUser.js
Loading it with consign as follows:
This would cause the split on _getRelativeTo to return ['/Users/myuser/project/','/controller/'] and the method would return '/controller/' thus not loading the controller.
Using the regex expression I applied it will return['/Users/myuser/project/','/controller/appUser.js'] as expected.
More clarification regarding the used regex can be found on this Stack Overflow post