-
Notifications
You must be signed in to change notification settings - Fork 3.3k
Fix ROCm lib names copy pattern to use wildcard version #33187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix ROCm lib names copy pattern to use wildcard version #33187
Conversation
(cherry picked from commit 577992d)
Summary of ChangesHello @phambinhfin, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses a critical issue in the build script where ROCm 7 wheels were not being copied due to a rigid version matching pattern. By introducing a wildcard ("rocm*") for ROCm versions, the script can now correctly identify and copy wheels for current and future ROCm releases. Additionally, it ensures that "jax-rocm-pjrt" wheels are properly categorized with a pure Python tag. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request fixes an issue with building ROCm wheels by using a wildcard to match different ROCm versions, which makes the build script more flexible. The change to add jax-rocm-pjrt to the list of py-tagged wheels is also correct.
My review includes one point of feedback on the build/build.py file. I've identified a potential issue where using a wildcard in the wheel_dir variable could cause problems for future editable builds for ROCm. While it doesn't break current functionality, it introduces fragility into the script. I've suggested making the code more robust to handle this case.
|
/gemini review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request addresses an issue with building ROCm wheels for different versions by using a wildcard pattern. The changes look good and correctly implement the intended fix. Specifically, the build script now uses rocm* to match any ROCm version for non-editable builds, which makes the process more flexible and future-proof. Additionally, jax-rocm-pjrt is now correctly tagged as a Python-version-independent wheel. The changes are clear and well-contained.
The build script failed to copy ROCm 7 wheels due to hardcoded version
pattern. Changed to use wildcard (rocm*) to match any ROCm version.
Changes:
Use rocm* wildcard instead of rocm{version} in wheel pattern
Add jax-rocm-pjrt to py-tagged wheels list
Supports jax_rocm60_, jax_rocm7_, and future versions