Skip to content

Fix ROCm lib names copy pattern to use wildcard version #33187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 14, 2025
Merged

Fix ROCm lib names copy pattern to use wildcard version #33187

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ccb5184
Fix ROCm lib names copy pattern to use wildcard version
phambinhfin Nov 3, 2025
e1b42a8
Fix ROCm wheel directory naming for editable builds
phambinhfin Nov 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion build/build.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -722,6 +722,13 @@ async def main():
wheel_dir = wheel.replace("cuda", f"cuda{cuda_major_version}").replace(
"-", "_"
)
elif "rocm" in wheel:
if args.editable:
# For editable builds, use the actual ROCm version since directory paths cannot contain wildcards
wheel_dir = wheel.replace("rocm", f"rocm{args.rocm_version}").replace("-", "_")
else:
# For non-editable builds, use wildcard pattern to match any ROCm version in glob patterns
wheel_dir = wheel.replace("rocm", "rocm*").replace("-", "_")
else:
wheel_dir = wheel

Expand All @@ -739,7 +746,7 @@ async def main():
wheel_version_suffix += (
f"+{wheel_git_hash}{custom_wheel_version_suffix}"
)
if wheel in ["jax", "jax-cuda-pjrt"]:
if wheel in ["jax", "jax-cuda-pjrt", "jax-rocm-pjrt"]:
python_tag = "py"
else:
python_tag = "cp"
Expand Down