Deprecate SplitFormWindowView & LearnMore Types#1838
Conversation
…re this is used. TODO: Figure out a way to unify LearnMoreButton and LearnMoreButton to pull from the same source
|
Let me know if I am off base with this. I just also added the This might not be possible. For now, I have this version where the learn more context is an optional input as a My only other thought is like a |
|
You're not too far off of what I've thought about to consolidate these views. To share the |
Oh perfect! I'll take a look at this tonight |
|
Okay! This is all functioning how I would expect this to now! I'm happy with where this stands but I'm not sure about naming/deprecation. Some of the items that I moved around are basically just our existing Finally, I've added a The description text for these Only other question. Do we like the section that leads to iOS Simulator.Screen.Recording.-.iPhone.17.Pro.-.2025-12-07.at.01.13.24.movtvOS Simulator.Screen.Recording.-.Apple.TV.4K.3rd.generation.-.2025-12-07.at.01.07.21.mov |
… place on iOS. Better to just keep this consistent and keep it out for both.
|
I've changed the usage of |
|
Ohhh that's a much cleaner way of this! Good call, I'll work on that this afternoon. Thank you for the suggestion! |
SplitFormWindowView in Favor of a Unified PlatformView for Form DataSplitFormWindowView & LearnMore Types
|
I should have all of these changes included now. Videos should be unchanged. This should be good to go for a review now. I moved the overloads to extensions for I might also want to do something similar for |
Co-authored-by: Ethan Pippin <ethanpippin2343@gmail.com>
Co-authored-by: Ethan Pippin <ethanpippin2343@gmail.com>
#Conflicts: # Shared/Extensions/Form.swift
Co-authored-by: Ethan Pippin <ethanpippin2343@gmail.com>
Co-authored-by: Ethan Pippin <ethanpippin2343@gmail.com>
…nto comboSettings
LePips
left a comment
There was a problem hiding this comment.
I've done my final cleanup. Something we'll have to consider in the future is to allow the Learn More on tvOS be selectable and present a scrollable view, in the event that the learn more is too long to be presented within its view.
|
Good call. I'll make an issue for that otherwise I'll forget. Lots to do haha |
Summary
Starts the process for: #1222
SplitFormWindowViewcurrently causes issues with building for both iOS and tvOS as it only exists in tvOS. Additionally, I understand that we are moving away from the builder pattern in favor of generics. My goal with this PR is to build the foundation so I can start migrating all of the settings over to a unified configuration.I've created a
PlatformFormthat mirrors our existingSplitFormWindowViewfor tvOS and a standard form layout for iOS. I've added some logic for initializing theSplitFormWindowView.descriptionViewsince we have a pattern we re-used with the systemImage and 400 width but this builds this in as an init. I've also added our recurring logic in at this level so it's easier to maintain as we change things.I was trying to figure out the right way of doing this. Whether I should do a
structwhere I basically retainSplitFormWindowViewas thetvOSViewof aPlatformViewor if this should be aprotocollike how I did this now. I preferred theprotocolsince I believe this is cleaner to just have a singlecontentViewinstead ofbody{SplitFormWindowView}. Let me know if I went the wrong way with this!I think I will want to move
CaseIterablePickerto shared and removeListRowMenuor vice versa to have a single type for this.If this all looks good, I would like to start moving form views over to a shared state when applicable in iOS and tvOS. This should resolve #1222 as part of this as well.
No screenshots as this is visually the same on both platforms.