Fix canceling outdated Maven projects#67
Merged
jakub-bochenski merged 1 commit intojenkinsci:masterfrom Apr 24, 2019
proski:maven-cancel
Merged
Fix canceling outdated Maven projects#67jakub-bochenski merged 1 commit intojenkinsci:masterfrom proski:maven-cancel
jakub-bochenski merged 1 commit intojenkinsci:masterfrom
proski:maven-cancel
Conversation
Author
|
Improved the commit message. |
proski
changed the title
Author
|
Updated for the forthcoming pipeline compatibility (#70). Instead of going from |
Author
|
Added a check for the result of |
Merged
jakub-bochenski
approved these changes
Apr 15, 2019
The original code would only look for instances of Build to be canceled. MavenBuild inherits from AbstractBuild but not from Build, so Maven builds would not be canceled. Use Run for elements of the job.getBuilds(), it is type safe and provides the necessary API. Use run.getId() in the log for better readability. Check the result of getExecutor(), it has @checkfornull attribute.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.