Fix FindBugs warnings about StashBuildTrigger#job being null#86
Merged
jakub-bochenski merged 1 commit intojenkinsci:masterfrom Jun 6, 2019
proski:job-not-null
Merged
Fix FindBugs warnings about StashBuildTrigger#job being null#86jakub-bochenski merged 1 commit intojenkinsci:masterfrom proski:job-not-null
jakub-bochenski merged 1 commit intojenkinsci:masterfrom
proski:job-not-null
Conversation
Author
|
The FindBugs issue causing the failure will be fixed when #67 is merged. This PR will be rebased. |
Author
|
Rebased, no FindBugs issues anymore. |
jakub-bochenski
approved these changes
May 31, 2019
|
Tried to resolve conflicts but I broke it. Can you take a look @proski ? |
Author
No problem, PRs that move code don't play well with others. I've rebased the PR. All the tests from |
|
... and there are conflicts again because I merged #98 :) |
Move startJob() and its dependencies from StashBuildTrigger to StashRepository. StashBuildTrigger objects can have a null job field, but it's impossible for StashRepository, which is instantiated once a non-null job is passed to StashBuildTrigger#start(). Move corresponding unit tests from StashBuildTriggerTest to StashRepositoryTest.
Author
No problem, resolved. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move startJob() and its dependencies from StashBuildTrigger to
StashRepository. StashBuildTrigger objects can have a null job field, but
it's impossible for StashRepository, which is instantiated once a
non-null job is passed to StashBuildTrigger#start().