Skip to content

feat: add priority field to todos #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jovanikos wants to merge 1 commit into
base: master
Choose a base branch
from
+9 −4
Open

feat: add priority field to todos #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/models/todo.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,8 @@ function getById(id) {
return todos.find(t => t.id === id) || null;
}

function create(title) {
const todo = { id: nextId++, title, done: false };
function create(title, priority) {
const todo = { id: nextId++, title, done: false, priority: priority || 'medium' };
todos.push(todo);
return todo;
}
Expand Down
9 changes: 7 additions & 2 deletions src/routes/todos.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@ const express = require('express');
const router = express.Router();
const Todo = require('../models/todo');

const VALID_PRIORITIES = ['low', 'medium', 'high'];

// GET /todos
router.get('/', (req, res) => {
res.json(Todo.getAll());
Expand All @@ -16,9 +18,12 @@ router.get('/:id', (req, res) => {

// POST /todos
router.post('/', (req, res) => {
const { title } = req.body;
const { title, priority } = req.body;
if (!title) return res.status(400).json({ error: 'title is required' });
res.status(201).json(Todo.create(title));
if (priority && !VALID_PRIORITIES.includes(priority)) {
return res.status(400).json({ error: 'priority must be low, medium or high' });
}
res.status(201).json(Todo.create(title, priority));
});

// PATCH /todos/:id
Expand Down