update #features to use native rollout method#25
Open
dfguo wants to merge 1 commit intojrallison:masterfrom
Open
update #features to use native rollout method#25dfguo wants to merge 1 commit intojrallison:masterfrom
dfguo wants to merge 1 commit intojrallison:masterfrom
Conversation
dfguo
commented
Feb 27, 2014
- get rid of monkey_patching
- use native #features method from rollout
- get rid of #add_feature
|
would be cool if this got merged and released. the current mechanism for hooking into rollout seems a little strange. |
Owner
|
Hey @dholdren, the current mechanism was the only option when this project was written (2013). Unfortunately, I'm not able to maintain this any longer. If someone would like to pick it up, I'm happy to talk about how that would work. Cheers, |
|
@dfguo thank you so much for the diff! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.