Skip to content

update #features to use native rollout method#25

Open
dfguo wants to merge 1 commit intojrallison:masterfrom
dfguo:master
Open

update #features to use native rollout method#25
dfguo wants to merge 1 commit intojrallison:masterfrom
dfguo:master

Conversation

@dfguo
Copy link
Copy Markdown

@dfguo dfguo commented Feb 27, 2014

  • get rid of monkey_patching
  • use native #features method from rollout
  • get rid of #add_feature

@dholdren
Copy link
Copy Markdown

would be cool if this got merged and released. the current mechanism for hooking into rollout seems a little strange.

@jrallison
Copy link
Copy Markdown
Owner

Hey @dholdren, the current mechanism was the only option when this project was written (2013).

Unfortunately, I'm not able to maintain this any longer. If someone would like to pick it up, I'm happy to talk about how that would work.

Cheers,
John

@nfedyashev
Copy link
Copy Markdown

@dfguo thank you so much for the diff!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants