Fix getJobStatus to correctly serialize the state changes #388
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
No linked issues found. Please add the corresponding issues in the pull request description. |
Miles-Garnsey
approved these changes
Sep 22, 2023
Contributor
Miles-Garnsey
left a comment
Miles-Garnsey
left a comment
There was a problem hiding this comment.
This PR is lacking any tests. However I have started writing one over here and it is only merging to the integration branch, so I'll approve and manually test from Reaper once merged.
This was referenced Sep 22, 2023
emerkle826
pushed a commit
that referenced
this pull request
Oct 12, 2023
* Correctly serialize and deserialize the statusChanges field * Use escaped JSON instead when returning from getJobStatus
emerkle826
pushed a commit
that referenced
this pull request
Oct 12, 2023
* Correctly serialize and deserialize the statusChanges field * Use escaped JSON instead when returning from getJobStatus
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.