Provide encode and decode #42
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I believe the cyrus default secprops come from a zeroed block of memory, which importantly means that `max_ssf` = 0 so encryption is actually disallowed by the client and server started by sasl_auth. In the long term, it's better if the security parameters come from the application but this patch sets up a reasonable and permissive default which should be no worse than the previous situation of preventing encryption altogether. Note that encryption will also require wiring the sasl_encode and sasl_decode interface functions.
These functions are necessary to communication when the connection is encrypted. TODO: - This is the only function which attempts to read either client or server state from arguments, probably not a good thing. - Need to be more careful with cleanup and error conditions.
adamwight
force-pushed
the
encode-decode
branch
from
47a4471 to
b4fc5c2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These functions are necessary when the connection is encrypted.
FIXME: