Simplify FormattableText trait; remove FormattableTextDyn#126
Merged
Conversation
dhardy
changed the title
dhardy
added a commit
to kas-gui/kas
that referenced
this pull request
Feb 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove
trait FormattableTextDynandstruct OwningVecIter: we have no use for them.Remove associated type
FormattableText::FontTokenIter, usingimpl Traitinstead (RPITIT was stabilised in 1.75.0).Add parameter
font: FontSelectorto fnFormattableText::font_tokens(this allows font effects to be relative to whatever baseline selector the text may use).Add requirements on font/effect token indices, with debug-mode tests.
Remove
Debugbound ontrait FormattableText.