refactor: clean up KeymanHosts usage and make consistent #272
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Splits the server-side and client-side references to keyman sites so that docker-based PHP can reference host.docker.internal on development machines for cross-references. * Removes some links to legacy sites such as sentry.keyman.com. * TODO: update to `BOOTSTRAP_VERSION=v0.17` in build.sh before merge. Relates-to: keymanapp/shared-sites#53 Relates-to: keymanapp/keyman.com#545
mcdurdin
added a commit
to keymanapp/keymanweb.com
that referenced
this pull request
Feb 13, 2025
* Splits the server-side and client-side references to keyman sites so that docker-based PHP can reference host.docker.internal on development machines for cross-references. * TODO: update to `BOOTSTRAP_VERSION=v0.17` in build.sh before merge. Relates-to: keymanapp/shared-sites#53 Relates-to: keymanapp/keyman.com#545 Relates-to: keymanapp/api.keyman.com#272
1 task
mcdurdin
added a commit
to keymanapp/help.keyman.com
that referenced
this pull request
Feb 13, 2025
* Splits the server-side and client-side references to keyman sites so that docker-based PHP can reference host.docker.internal on development machines for cross-references. * TODO: update to `BOOTSTRAP_VERSION=v0.17` in build.sh before merge. Relates-to: keymanapp/shared-sites#53 Relates-to: keymanapp/keyman.com#545 Relates-to: keymanapp/api.keyman.com#272 Relates-to: keymanapp/keymanweb.com#129
1 task
darcywong00
approved these changes
Feb 14, 2025
build.sh
Outdated
| readonly THIS_SCRIPT="$(readlink -f "${BASH_SOURCE[0]}")" | ||
| readonly BOOTSTRAP="$(dirname "$THIS_SCRIPT")/resources/bootstrap.inc.sh" | ||
| readonly BOOTSTRAP_VERSION=v0.11 | ||
| readonly BOOTSTRAP_VERSION=fix/keyman-hosts-for-server # v0.11 |
Contributor
There was a problem hiding this comment.
When keymanapp/shared-sites#53 lands
Suggested change
| readonly BOOTSTRAP_VERSION=fix/keyman-hosts-for-server # v0.11 | |
| readonly BOOTSTRAP_VERSION=v0.17 |
️✅ There are no secrets present in this pull request anymore.If these secrets were true positive and are still valid, we highly recommend you to revoke them. 🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request. |
mcdurdin
force-pushed
the
refactor/keyman-hosts-server-side-links
branch
from
92c90b9 to
27bbd75
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Splits the server-side and client-side references to keyman sites so that docker-based PHP can reference host.docker.internal on development machines for cross-references.
Removes some links to legacy sites such as sentry.keyman.com.
BOOTSTRAP_VERSION=v0.17in build.sh before merge.Relates-to: keymanapp/shared-sites#53
Relates-to: keymanapp/keyman.com#545