Skip to content

fix(web): prevent insert-delete edit sequences from aliasing as substitution edits 🚂 #15399

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
jahorton wants to merge 1 commit into
base: change/web/remove-duplicate-path-filtering
Choose a base branch
from
+12 −1
Draft

fix(web): prevent insert-delete edit sequences from aliasing as substitution edits 🚂 #15399

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion web/src/engine/predictive-text/worker-thread/src/main/correction/distance-modeler.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,6 +135,14 @@ export class SearchNode {
*/
private _inputCost?: number;

/**
* Counts the number of delete edits modeled directly after insert edits in
* this SearchNode's path. Such a sequence shows up within the calculation
* matrix as a substitution rather than two separate edits; we use this count
* to adjust accordingly.
*/
private readonly deleteAfterInsertEditPairs: number;

/**
* A unique identifier corresponding to the earliest SearchPath containing
* the correction-search graph edge represented by this instance.
Expand Down Expand Up @@ -164,6 +172,8 @@ export class SearchNode {
this.matchedTraversals = priorNode.matchedTraversals.slice();

this.lastEdgeType = param2 as PathEdge;
const isInsertAfterDelete = priorNode.lastEdgeType == PathEdge.INSERTION && this.lastEdgeType == PathEdge.DELETION;
this.deleteAfterInsertEditPairs = priorNode.deleteAfterInsertEditPairs + (isInsertAfterDelete ? 1 : 0);

// Do NOT copy over _inputCost; this is a helper-constructor for methods
// building new nodes... which will have a different cost.
Expand All @@ -180,6 +190,7 @@ export class SearchNode {
this.toKey = toKey || (x => x);
this.spaceId = spaceId;
this.lastEdgeType = PathEdge.ROOT;
this.deleteAfterInsertEditPairs = 0;
}
}

Expand All @@ -189,7 +200,7 @@ export class SearchNode {
* by the current node.
*/
get editCount(): number {
return this.calculation.getHeuristicFinalCost();
return this.calculation.getHeuristicFinalCost() + this.deleteAfterInsertEditPairs;
}

/**
Expand Down