-
-
Notifications
You must be signed in to change notification settings - Fork 130
maint(common): Update crowdin.yml to work with Crowdin CLI 4.0+
#15407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Matches the sample formatting in Crowdin CLI documentation https://support.crowdin.com/developer/configuration-file/
User Test ResultsTest specification and instructions User tests are not required |
crowdin.yml
Outdated
| # Files configuration | ||
| # | ||
| files: | ||
| files: [{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It should not be necessary to use json syntax in a yml file.
It would be cleaner to stay with yml syntax, or completely move the syntax for the entire file to json and rename the file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reverted the JSON syntax
ermshiperete
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Addresses #12116 and fixes #15392
This makes a few changes to the
crowdin.ymlconfiguration file to work on Crowdin CLI 4.0+ (which the GitHub action also uses).I've verified locally with Crowdin CLI v4.12.0.
JSON-ify the yml file so it matches the sample formatting in Crowdin CLI documentationel-polyton,shu-latn-n. These were flagging the Crowdin language mapping errors. I'm currently blocked on troubleshooting these until I can getsil_ltopscredentials in the Crowdin project.Test-bot: skip
Build-bot: skip