Skip to content

Rename sql to cesql #4737

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
knative-prow-robot merged 1 commit into from
Mar 9, 2022
Merged

Rename sql to cesql #4737

knative-prow-robot merged 1 commit into from
Mar 9, 2022

Conversation

@devguyio
Copy link
Contributor

@devguyio devguyio commented Feb 15, 2022

Updates the docs to match the change introduced here knative/eventing#6148

Proposed Changes

  • Update the new trigger filters docs to rename the sql field to cesql.

@devguyio
rename sql to cesql
55cf0fb 
Signed-off-by: Ahmed Abdalla <aabdelre@redhat.com>
@netlify
Copy link

netlify bot commented Feb 15, 2022 •
edited
Loading

✔️ Deploy Preview for knative ready!

🔨 Explore the source changes: 55cf0fb

🔍 Inspect the deploy log: https://app.netlify.com/sites/knative/deploys/620b9bbf36f6d8000709f319

😎 Browse the preview: https://deploy-preview-4737--knative.netlify.app/development/eventing/experimental-features/new-trigger-filters

@knative-prow-robot knative-prow-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 15, 2022
@knative-prow-robot
Copy link
Contributor

knative-prow-robot commented Feb 15, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: devguyio

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 15, 2022
@devguyio devguyio mentioned this pull request Feb 15, 2022
Merged
5 tasks
@csantanapr
Copy link
Member

csantanapr commented Feb 15, 2022

/hold
/lgtm

Looks good but the PR knative/eventing#6148 is not merged yet.
Feel free and remove hold once the PR is merge

@knative-prow-robot knative-prow-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 15, 2022
@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 15, 2022
@devguyio
Copy link
Contributor Author

devguyio commented Mar 9, 2022

/unhold

@knative-prow-robot knative-prow-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 9, 2022
@knative-prow-robot knative-prow-robot merged commit 46446cb into knative:main Mar 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@csantanapr csantanapr

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@devguyio @knative-prow-robot @csantanapr