Skip to content

Rename sql to cesql #4737

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
knative-prow-robot merged 1 commit into from
Mar 9, 2022
Merged

Rename sql to cesql #4737

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions docs/eventing/experimental-features/new-trigger-filters.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ metadata:
spec:
broker: default
filters:
- sql: "source LIKE '%commerce%' AND type IN ('order.created', 'order.updated', 'order.canceled')"
- cesql: "source LIKE '%commerce%' AND type IN ('order.created', 'order.updated', 'order.canceled')"
subscriber:
ref:
apiVersion: serving.knative.dev/v1
Expand Down Expand Up @@ -136,7 +136,7 @@ spec:
- exact:
type: com.github.push
```
### `sql`
### `cesql`

The provided [CloudEvents SQL Expression](https://github.com/cloudevents/spec/blob/main/cesql/spec.md) must evaluate to true.

Expand All @@ -148,7 +148,7 @@ metadata:
spec:
...
filters:
- sql: "source LIKE '%commerce%' AND type IN ('order.created', 'order.updated', 'order.canceled')"
- cesql: "source LIKE '%commerce%' AND type IN ('order.created', 'order.updated', 'order.canceled')"
```

## Conflict with the current `filter` field
Expand All @@ -169,7 +169,7 @@ spec:
myextension: my-extension-value
# Enhanced filters field. This will override the old filter field.
filters:
- sql: "type == 'dev.knative.foo.bar' AND myextension == 'my-extension-value'"
- cesql: "type == 'dev.knative.foo.bar' AND myextension == 'my-extension-value'"
subscriber:
ref:
apiVersion: serving.knative.dev/v1
Expand Down