Racing team full PR #190
Racing team full PR #190
Conversation
…n radius of the next 3 segments of 3 points
…curve radius calculation in trajectory.py. Add generate_circle.py to generate circle paths and add circle paths in knowledge/routes.
…total travel distance can vary)
krishauser
left a comment
krishauser
left a comment
There was a problem hiding this comment.
Commits not yet coordinated well with other teams.
There was a problem hiding this comment.
Are these parameter changes coordinated with the control team / parking team?
There was a problem hiding this comment.
These accelerator / braking ranges do not appear coordinated with the control team's changes. @Jugthegreat did you agree to these changes?
There was a problem hiding this comment.
Please take this out of the PR if nothing is changing
There was a problem hiding this comment.
It's not the function of a trajectory to specify velocity limits. That's more of the function of a route or a plan. We talked about the definition of a trajectory in class.
…ax speed back to 10.0
|
Changed current.yaml to have separate racing parameters as discussed with the control team. |
krishauser
left a comment
krishauser
left a comment
There was a problem hiding this comment.
The changes recently made didn't address the issues. Sorry, your PR wasn't successfully approved.
|
I'm sorry, but what issues are still remaining? We addressed the Trajectory issue by taking out velocities, and we switched the racing settings in current.yaml to be separate from the other settings. I'm not sure what other issues there were, other than having a few "Agent" references left... but I mentioned in the PR comments that that was only so that we could still use the Klampt simulation. If you'd like we could take that out as well. |
|
You made surface-level changes to address my review but you didn't test the code. |
|
I did test the code in simulation, would you like to see it working? |
The reason why we did switch back to just timings is because Diego and I tested it last night and it worked in sim. |
|
First PR for Racing team. Includes: