Skip to content

Conversation

mcruzdev
Copy link

@mcruzdev mcruzdev commented Sep 6, 2024

Fixes #37

@mcruzdev
Copy link
Author

@ederign @thesuperzapper @kimwnasptd, could you do a first review?

Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from kimwnasptd. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Signed-off-by: Matheus Cruz <matheuscruz.dev@gmail.com>
@thesuperzapper thesuperzapper changed the title feat: implement VirtualService reconciliation feat(ws): implement VirtualService reconciliation Dec 11, 2024
@thesuperzapper thesuperzapper added kind/enhancement kind - new features or changes area/controller area - related to controller components labels Jan 16, 2025
@andyatmiami
Copy link
Contributor

Thank you for the contribution here - but this work has been picked up by another community member who was been a little more engaged recently in WG meetings and better handles some other changes that have been implemented since this PR was originally raised.

Work is now being implemented under #500.

/close

@google-oss-prow google-oss-prow bot closed this Sep 29, 2025
Copy link

@andyatmiami: Closed this PR.

In response to this:

Thank you for the contribution here - but this work has been picked up by another community member who was been a little more engaged recently in WG meetings and better handles some other changes that have been implemented since this PR was originally raised.

Work is now being implemented under #500.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@github-project-automation github-project-automation bot moved this from Needs Triage to Done in Kubeflow Notebooks Sep 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/controller area - related to controller components kind/enhancement kind - new features or changes size/XXL

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Implement VirtualService reconciliation

4 participants