-
Notifications
You must be signed in to change notification settings - Fork 66
feat(ws): implement VirtualService reconciliation #42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
6764331
to
b3bc719
Compare
workspaces/controller/internal/controller/workspace_controller.go
Outdated
Show resolved
Hide resolved
@ederign @thesuperzapper @kimwnasptd, could you do a first review? |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Matheus Cruz <matheuscruz.dev@gmail.com>
Thank you for the contribution here - but this work has been picked up by another community member who was been a little more engaged recently in WG meetings and better handles some other changes that have been implemented since this PR was originally raised. Work is now being implemented under #500. /close |
@andyatmiami: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Fixes #37