Skip to content

feat(ws): setup virtualservice to route traffic for workspaces #500

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: notebooks-v2
Choose a base branch
from
Open

feat(ws): setup virtualservice to route traffic for workspaces #500

wants to merge 1 commit into from

Conversation

harshad16
Copy link

@harshad16 harshad16 commented Jul 24, 2025 •
edited
Loading

related: #37
follow-up: #42

Descriptions:

The PR allow controller to connect each workspace with an endpoint that is reachable under the istio mesh.
This virtualservice follow the pattern of unqiue name, so it doesnt collide with notebook v1, if running in the same cluster parallely.

Setup:

The setup require to set the istio deployment in places.
for initial setup:

CRD change with port in podtemplate:
#507

demo:
Screencast from 2025-07-28 16-43-01.webm

@github-project-automation github-project-automation bot moved this to Needs Triage in Kubeflow Notebooks Jul 24, 2025
@google-oss-prow google-oss-prow bot added area/controller area - related to controller components area/v2 area - version - kubeflow notebooks v2 labels Jul 24, 2025
@harshad16 harshad16 changed the title feat: Setup virtualservice to route traffic to relevant workspace feat(ws): setup virtualservice to route traffic to relevant workspace Jul 24, 2025
@harshad16 harshad16 force-pushed the virtualservice branch 2 times, most recently from 4dcf94e to 50b6026 Compare July 31, 2025 05:12
@harshad16 harshad16 marked this pull request as ready for review July 31, 2025 05:13
@thesuperzapper
Copy link
Member

/ok-to-test

@google-oss-prow google-oss-prow bot added area/backend area - related to backend components size/XL and removed size/L labels Sep 18, 2025
@andyatmiami andyatmiami mentioned this pull request Sep 22, 2025
Open
2 tasks
thesuperzapper
thesuperzapper reviewed Sep 25, 2025
View reviewed changes
workspaces/backend/internal/models/workspaces/funcs.go
services[i].HttpService = &HttpService{
DisplayName: ptr.Deref(port.DisplayName, wskPodTemplatePorts[i].DefaultDisplayName),
HttpPath: fmt.Sprintf("/workspace/%s/%s/%s/", ws.Namespace, ws.Name, port.Id),
HttpPath: fmt.Sprintf("/workspace/connect/%s/%s/%s/", ws.Namespace, ws.Name, port.Id),
Copy link
Member

@thesuperzapper thesuperzapper Sep 25, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note, we should update all other instances which look like /workspace/... path string formatters (do a search over the whole project)

In addition, we should update the doc string of the WorkspaceKind types (in controller) and the doc string of the WorkspaceKind same (which should usually match the go doc string anyway).

@andyatmiami andyatmiami mentioned this pull request Sep 29, 2025
Closed
@google-oss-prow google-oss-prow bot added the area/frontend area - related to frontend components label Oct 2, 2025
@harshad16
setup virtualservice to route traffic for workspaces
b2571d9 
- Update the helper func with CopyDeepVirtualService

Signed-off-by: Harshad Reddy Nalla <hnalla@redhat.com>
@google-oss-prow Google OSS Prow
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign andyatmiami, paulovmr for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot removed the size/XL label Oct 2, 2025
@harshad16 harshad16 changed the title feat(ws): setup virtualservice to route traffic to relevant workspace feat(ws): setup virtualservice to route traffic for workspaces Oct 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thesuperzapper thesuperzapper thesuperzapper left review comments

@andyatmiami andyatmiami Awaiting requested review from andyatmiami

@kimwnasptd kimwnasptd Awaiting requested review from kimwnasptd

Assignees
No one assigned
Labels
area/backend area - related to backend components area/controller area - related to controller components area/frontend area - related to frontend components area/v2 area - version - kubeflow notebooks v2 ok-to-test size/L
Projects
Kubeflow Notebooks
Status: Needs Triage
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@harshad16 @thesuperzapper