unitest-cli-refactor#126
Merged
austintwang merged 4 commits intokundajelab:masterfrom Dec 14, 2025
Merged
Conversation
Open
Contributor
Author
|
Hi @austintwang, Did you had opportunity to review PR above? This branch should be straightforward to merge given it is just adding test case and refactors CLI. |
Contributor
Author
|
Hi @austintwang, I want to just ping you for your feedback on this pull request. |
austintwang
requested changes
Nov 1, 2025
Member
austintwang
left a comment
austintwang
left a comment
There was a problem hiding this comment.
Appreciate your patience, and once again, thanks for doing this!
Overall, it looks good, the one TODO is to make sure the CLI is up to date.
Contributor
Author
|
Hi @austintwang, I updated CLI to reflect the changes you mentioned. Also, |
austintwang
approved these changes
Dec 14, 2025
Member
austintwang
left a comment
austintwang
left a comment
There was a problem hiding this comment.
Appreciate your patience! This looks good to me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unit tested and cli refactored with click: See the unit-test which check results are exactly same with original. The re-runing this test-case in each downstream PR confirms that results are exactly same.
See original PR: #124