fix: auto-supersede stale secure env requests instead of rejecting with busy#531
Merged
fix: auto-supersede stale secure env requests instead of rejecting with busy#531
Conversation
…th busy When a controller-cli process dies before the user interacts with the modal, the active request state was never cleaned up, permanently blocking all future requests with "busy". Now, new requests auto-cancel any existing one by sending a "superseded" response through the old channel, unblocking the stuck handler thread. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
controller-cliprocess dies before the user interacts with the secure env modal, the active request state was never cleaned up, permanently blocking all future requests with "busy"Test plan
supersedes_existing_active_secure_env_request,supersede_notifies_previous_cli_via_channel,supersedes_existing_request_and_dispatches_new_one)controller-cli env settwice — second call should succeed instead of returning "busy"🤖 Generated with Claude Code