Fix sidebar workspace dropdown split, project fetching, and create-project dialog error handling by Copilot · Pull Request #1 · lakubuDavid/mini-cms

Copilot · 2026-03-27T06:01:43Z

The sidebar workspace button had no actual dropdown — the entire element (including ChevronDown) was a single <Link> navigating to the workspace page. Project fetching on the dashboard was broken by a useEffect dependency bug and incorrect history.replaceState usage. The create-project dialog silently got stuck in a pending state on server errors.

Sidebar workspace: split button and dropdown

The workspace row is now split into two interactive zones within a shared bordered container:

Left (icon + name + slug) → <Link to="/dashboard/workspace">
Right (ChevronDown) → toggles a floating dropdown menu (mirrors the profile-menu pattern) with a "Workspace settings" entry

Project fetching: fix `useEffect` dependency and `replaceState` state loss

currentSearch was new URLSearchParams(window.location.search) computed inline — a new object reference on every render — causing useEffect to fire on every render. Replaced with rawSearch (plain string):

// Before — new object every render, effect runs on every render
const currentSearch = new URLSearchParams(window.location.search);

// After — stable string, effect only fires when search actually changes
const rawSearch = window.location.search;

replaceState was called with {} as the state argument, wiping TanStack Router's stored history state and breaking subsequent route reads. Fixed to preserve the existing state:

// Before — nukes router-internal history state
window.history.replaceState({}, "", newUrl);
window.dispatchEvent(new PopStateEvent("popstate"));

// After — preserves router state; event carries state too
window.history.replaceState(window.history.state, "", newUrl);
window.dispatchEvent(new PopStateEvent("popstate", { state: window.history.state }));

Path comparison now normalises trailing slashes (pathname.replace(/\/$/, "")) so /dashboard/ matches the same conditions as /dashboard.

Create-project dialog: add `try/catch/finally`

createProjectServerFn always re-throws on failure. Without a try/catch, setPending(false) was never reached, leaving the dialog stuck in "Creating…" with no visible error. Wrapped in try/catch/finally — finally always resets pending state; catch surfaces the server error message.

…dialog Agent-Logs-Url: https://github.com/lakubuDavid/mini-cms/sessions/4992ee7a-68f9-4ba9-861c-95ad5c59eeb7 Co-authored-by: lakubuDavid <32282902+lakubuDavid@users.noreply.github.com>

vercel · 2026-03-27T06:01:47Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
mini-cms	Ready	Preview, Comment	Mar 28, 2026 10:54am
mini-cms-docs	Ready	Preview, Comment	Mar 28, 2026 10:54am

Copilot

Pull request overview

Fixes several dashboard UX/state issues: adds a real workspace dropdown in the sidebar, stabilizes project-selection effects and preserves router history state when updating query params, and prevents the create-project dialog from getting stuck pending on server errors.

Changes:

Split the sidebar workspace row into a link area + chevron-triggered dropdown.
Fix dashboard project-selection useEffect dependencies and preserve window.history.state when calling replaceState/dispatching popstate.
Wrap create-project flow in try/catch/finally to always clear pending state and surface errors.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

File	Description
apps/web/src/routes/dashboard/route.tsx	Stabilizes URL/query handling and adds a workspace dropdown menu UI in the sidebar.
apps/web/src/routes/dashboard/index.tsx	Improves create-project dialog reliability by handling server errors and always resetting pending state.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-03-28T12:40:27Z

+                className="fixed inset-0 z-40"
+                onClick={() => setWorkspaceOpen(false)}
+              />
+              <div className="absolute bottom-full left-0 z-50 mb-2 w-full rounded-xl border border-stone-200 bg-white p-3 shadow-lg dark:border-stone-700 dark:bg-stone-900">


The workspace dropdown backdrop only closes on click; there’s no keyboard handling (e.g., Escape) so keyboard users can get stuck with the menu open. Consider matching the pattern used in apps/web/src/routes/dashboard/api-keys.tsx:549-554 by adding an onKeyDown Escape handler (and/or a document keydown listener while open) so the menu can be dismissed without a pointer.

Suggested change

<div className="absolute bottom-full left-0 z-50 mb-2 w-full rounded-xl border border-stone-200 bg-white p-3 shadow-lg dark:border-stone-700 dark:bg-stone-900">

<div

className="absolute bottom-full left-0 z-50 mb-2 w-full rounded-xl border border-stone-200 bg-white p-3 shadow-lg dark:border-stone-700 dark:bg-stone-900"

onKeyDown={(event) => {

if (event.key === "Escape") {

setWorkspaceOpen(false);

}

}}

>

Copilot · 2026-03-28T12:40:27Z

+            <button
+              type="button"
+              onClick={() => setWorkspaceOpen(!workspaceOpen)}
+              aria-label="Workspace menu"
+              className="flex items-center justify-center px-2.5 py-2 text-stone-400 transition hover:bg-stone-100 hover:text-stone-600 dark:hover:bg-stone-800 dark:hover:text-stone-300 border-l border-stone-200 dark:border-stone-800"
+            >
+              <ChevronDown className="h-4 w-4" />
+            </button>


New workspace dropdown behavior isn’t covered by existing Playwright e2e tests (no tests reference the “Workspace menu” button / “Workspace settings” entry). Adding a regression test that opens the dropdown via the chevron button and verifies the “Workspace settings” link navigates correctly would help prevent future sidebar regressions.

Copilot · 2026-03-28T12:40:28Z

+    try {
+      const project = await createProjectServerFn({
+        data: { name, slug },
+      });

-    setPending(false);
+      if (!project) {
+        setError("Unable to create project. Please try again.");
+        return;
+      }

-    if (!project) {
-      setError("Unable to create project. Please try again.");
-      return;
+      setName("");
+      setSlug("");
+      setOpen(false);
+      props.onCreated();
+    } catch (cause) {
+      setError(
+        cause instanceof Error
+          ? cause.message
+          : "Unable to create project. Please try again.",
+      );
+    } finally {
+      setPending(false);
    }


The create-project error-handling path (server throws -> error message shown + pending resets) isn’t exercised by automated tests. Since the repo already has Playwright e2e coverage, adding a test that forces createProjectServerFn to fail (or intercepts the network request) and asserts the dialog exits the “Creating…” state and displays the error would prevent regressions.

Fix sidebar workspace dropdown, project fetching, and create-project …

a38507a

…dialog Agent-Logs-Url: https://github.com/lakubuDavid/mini-cms/sessions/4992ee7a-68f9-4ba9-861c-95ad5c59eeb7 Co-authored-by: lakubuDavid <32282902+lakubuDavid@users.noreply.github.com>

Copilot AI assigned Copilot and lakubuDavid Mar 27, 2026

Copilot created this pull request from a session on behalf of lakubuDavid March 27, 2026 06:01 View session

lakubuDavid marked this pull request as ready for review March 28, 2026 12:36

Copilot AI review requested due to automatic review settings March 28, 2026 12:36

Copilot started reviewing on behalf of lakubuDavid March 28, 2026 12:36 View session

Copilot AI reviewed Mar 28, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix sidebar workspace dropdown split, project fetching, and create-project dialog error handling#1

Fix sidebar workspace dropdown split, project fetching, and create-project dialog error handling#1
Copilot wants to merge 1 commit intomainfrom
copilot/fix-dashboards-sidebar-button-dropdown

Copilot AI commented Mar 27, 2026

Uh oh!

vercel Bot commented Mar 27, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Mar 28, 2026

Uh oh!

Copilot AI Mar 28, 2026

Uh oh!

Copilot AI Mar 28, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

-              <div className="absolute bottom-full left-0 z-50 mb-2 w-full rounded-xl border border-stone-200 bg-white p-3 shadow-lg dark:border-stone-700 dark:bg-stone-900">
+              <div
+                className="absolute bottom-full left-0 z-50 mb-2 w-full rounded-xl border border-stone-200 bg-white p-3 shadow-lg dark:border-stone-700 dark:bg-stone-900"
+                onKeyDown={(event) => {
+                  if (event.key === "Escape") {
+                    setWorkspaceOpen(false);
+                  }
+                }}
+              >

Conversation

Copilot AI commented Mar 27, 2026

Sidebar workspace: split button and dropdown

Project fetching: fix useEffect dependency and replaceState state loss

Create-project dialog: add try/catch/finally

Uh oh!

vercel Bot commented Mar 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Mar 28, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 28, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 28, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Project fetching: fix `useEffect` dependency and `replaceState` state loss

Create-project dialog: add `try/catch/finally`

vercel Bot commented Mar 27, 2026 •

edited

Loading