Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/wsproxy for browser frontend/wsproxy for dev9517023d) Dockerfile builds checksum worker as a separate sidecar at/app/lish/checksum-worker.jsto align with the runtime resolution model PR fix(app): ship checksum worker sidecar across all bundle formats #27 introducesThis PR's Dockerfile produces
/app/lish/checksum-worker.jsnext to/app/lish-backend,but the backend on this branch still resolves the worker via the buggy
new URL('./lish/checksum-worker.js', import.meta.url).hrefpath(
backend/src/app.ts:22), which evaluates to a/$bunfs/root/...virtual URLin compiled binaries.
PR #27 (
fix/checksum-worker-cross-platform-bundles) replaces that withpathToFileURL(join(dirname(execPath), 'lish', 'checksum-worker.js')). WithoutPR #27 merged first, the worker file is shipped but the backend cannot find it
at runtime — LISH creation will hang at 0% the same way it did pre-fix on Windows.
After PR #27 lands and this branch rebases on
main, no further code changesare needed here — the Dockerfile fix in
9517023dalready produces the layoutPR #27's runtime expects.
Verification
bun test tests/api-url.test.tsinfrontend/→ 5 passdocker build -f docker/Dockerfile .→ image contains/app/lish-backend(103 MB) and/app/lish/checksum-worker.js(759 B)lishs.createfrom companion container reaches backend, but hangs as expected without PR fix(app): ship checksum worker sidecar across all bundle formats #27's worker URL fix on this branch (proves the dependency, not a defect of this PR)