fix(app): ship checksum worker sidecar across all bundle formats#27
Open
fix(app): ship checksum worker sidecar across all bundle formats#27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Fixes the checksum worker not being shipped (or not discoverable) in production
bundles. Original Windows-only ZIP fix is extended to all bundle formats
(NSIS/MSI/Windows ZIP, macOS DMG/ZIP, Linux DEB/RPM/Pacman/AppImage/ZIP),
adds worker lifecycle hardening, and gates the build on cross-package tests.
Why
Bun-compiled binaries see
import.meta.urlas/$bunfs/root/<binary>(virtual),so the worker URL resolved to a non-existent file. Tauri bundles also weren't
copying the worker into the resource directory. Result: silent 0% hang on
LISH creation, then segfault on stop.
The fix:
<dir(execPath)>/lish/checksum-worker.jsbundle.resourcesincludes the worker on all 3 platformsapp/build.shZIP/DEB/RPM staging copies the workerworker.terminate()swapped forworker.unref()on Windows compiled (Bun segfault avoided)Verified
Pre-build gate: typecheck + 405 unit tests + frontend
bun run check+ shared/cli typecheck.Skip with
SKIP_TESTS=1only in emergencies.Commits (13)
worker.unrefintersectionPR #26's
docker/Dockerfilecompilesapp.tsandchecksum-worker.tswithtwo entry points into a single
--outfile, which doesn't produce the sidecarthis PR's runtime resolution requires. Whichever PR lands second must split
the Docker build into two
bun buildsteps mirroringbackend/build.sh.Out of scope
bundle.externalBin+tauri-plugin-shellsidecar APIbundle.resourcesinto sharedtauri.conf.json(RFC 7396 merge behavior unclear)backend/build.{sh,bat}+app/build.bat/usr/lib/libershare/instead of/usr/bin/lish/)