fix(desktop): create Sentry release before finalize#642
Merged
jeevanpillay merged 1 commit intomainfrom May 6, 2026
Merged
Conversation
PR #641 dropped the `sentry-cli releases new` step from the upload flow, assuming `sourcemaps upload --release X` would auto-create the release entity. It does not — it writes the artifact bundle and tags it with a release name, but the release record itself stays absent. The subsequent `releases finalize` then errors with "Release not found" and the workflow fails after every sourcemap has already uploaded. Restore `sentry-cli releases new <release>` as the first step. The full flow is now: new -> upload (main) -> upload (renderer) -> finalize. Failed run that surfaced this: https://github.com/lightfastai/lightfast/actions/runs/25420266590 Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub. 3 Skipped Deployments
|
4 tasks
jeevanpillay
added a commit
that referenced
this pull request
May 6, 2026
Pull in 5 desktop release PRs that landed since fork: - #638 codesign pre-fixes - #639 release-pipeline fixes - #640 Vite sourcemaps - #641 observability hardening (IPC routing + debug-id symbolication) - #642 Sentry release/finalize fix Conflicts resolved: - apps/desktop/src/main/windows/factory.ts — comment-only divergence on the Vite/CJS __dirname workaround. Took main's more detailed wording. - apps/desktop/src/renderer/src/main.ts — main removed renderer-side Sentry init (the v10 SDK silently no-op'd; events forward via IPC to main now). Our HEAD's initSentryBrowser block referenced sentryInit which main also dropped. Took main's version. - pnpm-lock.yaml — regenerated against the merged package.json files. Verified: 38/38 desktop tests pass; @lightfast/desktop and @lightfast/app typechecks clean. Live PKCE sign-in re-verification deferred to post-commit step.
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PR #641 dropped `sentry-cli releases new` from the upload flow, assuming `sourcemaps upload --release X` would auto-create the release entity. It doesn't — it uploads the artifact bundle and tags it, but the release record itself stays absent. `releases finalize` then errors with "Release not found" and the workflow fails after sourcemaps have already uploaded.
Failed run: 25420266590
Fix
Restore `sentry-cli releases new ` as the first step. Full flow: new → upload (main) → upload (renderer) → finalize.
Test plan