Skip to content

fix(desktop): create Sentry release before finalize #642

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jeevanpillay merged 1 commit into from
May 6, 2026
+9 −4
Merged

fix(desktop): create Sentry release before finalize #642

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions apps/desktop/scripts/upload-sourcemaps.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,11 +38,16 @@ function sentry(args) {
}

// Modern artifact-bundle flow with debug-id matching. `sourcemaps inject`
// runs in `forge.config.ts`'s prePackage hook so the injected //# debugId=
// comments land in the asar; here we only `upload`. Stack frames in Sentry
// resolve via debug-id, which avoids URL-prefix mismatches between the
// uploaded path (`assets/index-*.js`) and the runtime frame
// runs in `forge.config.ts`'s `packageAfterCopy` hook so the injected
// //# debugId= comments land in the asar; here we only `upload`. Stack
// frames in Sentry resolve via debug-id, sidestepping URL-prefix mismatches
// between the uploaded path (`assets/index-*.js`) and the runtime frame
// (`app:///.vite/renderer/main_window/assets/index-*.js`).
//
// `sourcemaps upload --release` writes the artifact bundle but does NOT
// create the release entity. `releases new` is required before finalize,
// otherwise finalize errors with "Release not found".
sentry(["releases", "new", release]);
sentry(["sourcemaps", "upload", "--release", release, buildDir]);
sentry(["sourcemaps", "upload", "--release", release, rendererDir]);
sentry(["releases", "finalize", release]);
Expand Down
Loading