Add shellcheck to CI and a progress bar for sed'ing in genbindings.sh
#127
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tnull
force-pushed
the
2024-06-shellcheck-and-progress
branch
from
aa0536e to
ac0c537
Compare
tnull
force-pushed
the
2024-06-shellcheck-and-progress
branch
from
ac0c537 to
4188e53
Compare
TheBlueMatt
reviewed
Jun 6, 2024
| ./a.out | ||
| fi | ||
| fi | ||
| # And run the C++ demo app |
There was a problem hiding this comment.
The indentation here is wrong now, we're still in a top-level if.
| EXTRA_TARGETS=( $LDK_C_BINDINGS_EXTRA_TARGETS ) | ||
| EXTRA_CCS=( $LDK_C_BINDINGS_EXTRA_TARGET_CCS ) | ||
| EXTRA_LINK_LTO=( $LDK_C_BINDINGS_EXTRA_TARGET_LINK_LTO ) | ||
| EXTRA_TARGETS=( "$LDK_C_BINDINGS_EXTRA_TARGETS" ) |
There was a problem hiding this comment.
No, this breaks the array expansion.
| fi | ||
| # Finally, sanity-check the generated C and C++ bindings with demo apps: | ||
| # Naively run the C demo app: | ||
| gcc "$LOCAL_CFLAGS" -Wall -g -pthread demo.c target/debug/libldk.a -ldl -lm |
There was a problem hiding this comment.
No, we want the arguments to expand, quoting restricts them to a single argument.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As running the C++
sedstep is insanely slow, we print a simple progress bar to allow checking if progress is made.We also run shellcheck on
genbindings.shand enforce it in CI.