Skip to content

Add shellcheck to CI and a progress bar for sed'ing in genbindings.sh #127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Add shellcheck to CI and a progress bar for sed'ing in genbindings.sh #127

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
21e6ec3
Print a simple progress bar while `sed`'ing
tnull Jun 6, 2024
eaec5c5
Fix `shellcheck` warnings for `genbindings.sh`
tnull Jun 6, 2024
2a36243
Shellcheck `genbindings.sh` in CI
tnull Jun 6, 2024
b30af20
Fix indentation to use tabs
tnull Jun 6, 2024
4188e53
Fix minor typos in CI
tnull Jun 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,20 +15,25 @@ jobs:
env:
TOOLCHAIN: stable
steps:
- name: Install native Rust toolchain, Valgrind, and build utilitis
- name: Install native Rust toolchain, Valgrind, and build utilities
if: "matrix.distro == 'debian:bookworm'"
run: |
apt-get update
apt-get -y dist-upgrade
apt-get -y install cargo libstd-rust-dev-wasm32 wasi-libc valgrind lld git g++ clang wget
- name: Install native Rust toolchain, Valgrind, and build utilitis
- name: Install native Rust toolchain, Valgrind, and build utilities
if: "matrix.distro == 'fedora:39'"
run: |
dnf -y install cargo rust-std-static-wasm32-wasi valgrind lld git g++ clang wget which diffutils
- name: Checkout source code
uses: actions/checkout@v2
with:
fetch-depth: 0
- name: shellcheck the genbindings script
if: "matrix.distro == 'debian:bookworm'"
run: |
apt-get -y install shellcheck
shellcheck -e SC2005,SC2002,SC2001 genbindings.sh
- name: Sanity test bindings against Cargo.toml RL
working-directory: lightning-c-bindings
run: |
Expand Down Expand Up @@ -80,7 +85,7 @@ jobs:
env:
TOOLCHAIN: stable
steps:
- name: Install native Rust toolchain, Valgrind, and build utilitis
- name: Install native Rust toolchain, Valgrind, and build utilities
run: |
apt-get update
apt-get -y dist-upgrade
Expand Down
Loading