🐛 Fix lock screen pause not stopping TTS playback#28
Draft
williamchong wants to merge 1 commit intolikecoin:mainfrom
Draft
🐛 Fix lock screen pause not stopping TTS playback#28williamchong wants to merge 1 commit intolikecoin:mainfrom
williamchong wants to merge 1 commit intolikecoin:mainfrom
Conversation
Remove custom auto-resume logic that could not distinguish lock screen pause (user intent) from OS audio interruption, causing pause from media controls to be immediately undone. expo-audio handles interruption recovery natively via AVAudioSession (iOS) and AudioFocus (Android).
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes an issue where pausing from lock screen media controls would be immediately undone due to custom auto-resume logic in the native audio bridge. The change aligns behavior with expo-audio’s native interruption recovery so user-initiated pauses are respected.
Changes:
- Removed custom auto-resume retry state/timer and the “unexpected pause → auto play()” loop.
- Simplified pause/resume/stop paths by removing
userPausedand auto-resume reset logic. - Added an in-code note documenting why auto-resume logic should not be reintroduced in the status listener.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove custom auto-resume logic that could not distinguish lock screen pause (user intent) from OS audio interruption, causing pause from media controls to be immediately undone. expo-audio handles interruption recovery natively via AVAudioSession (iOS) and AudioFocus (Android).