Skip to content

🐛 Fix lock screen pause not stopping TTS playback #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
williamchong wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

🐛 Fix lock screen pause not stopping TTS playback #28

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
55 changes: 9 additions & 46 deletions services/audio-bridge.native.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,16 +48,12 @@ let loadPromise: Promise<void> = Promise.resolve();
let notifyWebView: SendToWebView | null = null;
let lastSentState = '';

// Auto-resume & stuck detection state
const MAX_AUTO_RESUME_RETRIES = 3;
// Stuck detection state
// Longer than web player's 5s because iOS uses blocking=1 URLs where the
// server generates the full TTS audio before responding.
const STUCK_TIMEOUT_MS = 15000;
let active = false;
let userPaused = false;
let audible = false;
let autoResumeRetries = 0;
let autoResumeTimer: ReturnType<typeof setTimeout> | null = null;
let stuckTimer: ReturnType<typeof setTimeout> | null = null;
let stuckRetried = false;
let errored = false;
Expand Down Expand Up @@ -142,13 +138,6 @@ function getOrCreatePlayers(): AudioPlayer {
return getActivePlayer()!;
}

function clearAutoResumeTimer(): void {
if (autoResumeTimer) {
clearTimeout(autoResumeTimer);
autoResumeTimer = null;
}
}

function clearStuckTimer(): void {
if (stuckTimer) {
clearTimeout(stuckTimer);
Expand All @@ -160,8 +149,6 @@ function resetRecoveryState(): void {
audible = false;
errored = false;
stuckRetried = false;
autoResumeRetries = 0;
clearAutoResumeTimer();
}

function armStuckTimer(): void {
Expand Down Expand Up @@ -284,7 +271,6 @@ async function doLoad(msg: LoadMessage): Promise<void> {
currentRate = msg.rate;
lastFinishTime = 0;
active = true;
userPaused = false;
clearStuckTimer();
resetIdle();

Expand All @@ -297,28 +283,20 @@ async function doLoad(msg: LoadMessage): Promise<void> {

export function handlePause(): void {
active = false;
userPaused = true;
audible = false;
clearAutoResumeTimer();
clearStuckTimer();
getActivePlayer()?.pause();
}

export function handleResume(): void {
clearAutoResumeTimer();
autoResumeRetries = 0;
active = true;
userPaused = false;
errored = false;
stuckRetried = false;
// No armStuckTimer() — on resume the source is already buffered.
// OS-interruption stalls are handled by the auto-resume retry loop.
getActivePlayer()?.play();
}

export function handleStop(): void {
active = false;
userPaused = false;
resetRecoveryState();
clearStuckTimer();
// Skip replace(null) — iOS expo-audio cannot cast null to AudioSource.
Expand All @@ -337,7 +315,6 @@ export function handleSkipTo(index: number): void {
const player = getActivePlayer();
if (!player || index < 0 || index >= queue.length) return;
active = true;
userPaused = false;
lastFinishTime = 0;

const lastIndex = currentIndex;
Expand Down Expand Up @@ -381,7 +358,6 @@ export function registerEventListeners(sendToWebView: SendToWebView) {
if (status.playbackState === 'failed') {
errored = true;
clearStuckTimer();
clearAutoResumeTimer();
notifyWebView?.({ type: 'error', message: 'Playback failed' });
return;
}
Expand All @@ -400,32 +376,20 @@ export function registerEventListeners(sendToWebView: SendToWebView) {
notifyWebView?.({ type: 'playbackState', state });
}

// Audio reached playing state — clear stuck timer, reset resume retries
// NOTE: Do NOT add auto-resume logic here (e.g. detecting unexpected pauses
// and calling play() after a timeout). expo-audio already handles OS audio
// interruption recovery natively — iOS via AVAudioSession.interruptionNotification
// with shouldResume, Android via AUDIOFOCUS_GAIN. A custom auto-resume cannot
// distinguish lock screen pause (user intent) from OS interruption, causing
// lock screen pause to be ineffective and the queue to keep advancing.

// Audio reached playing state — clear stuck timer
if (state === 'playing') {
audible = true;
errored = false;
autoResumeRetries = 0;
clearStuckTimer();
}

// Detect unexpected pause (OS interruption: phone call, Siri, other app).
// The `audible` guard ensures this only fires on the playing→paused transition,
// not on every subsequent paused status tick.
if (state === 'paused' && audible && !userPaused && active && !errored
&& !autoResumeTimer && !status.didJustFinish) {
audible = false;
if (autoResumeRetries < MAX_AUTO_RESUME_RETRIES) {
autoResumeRetries += 1;
autoResumeTimer = setTimeout(() => {
autoResumeTimer = null;
if (active && !audible && !userPaused && !errored) {
audible = true; // re-arm so next paused status can trigger another retry
getActivePlayer()?.play();
}
}, 1000);
}
}

// Trigger preload once playback starts
if (state === 'playing' && preload.readyIndex < 0 && preload.loadingIndex < 0) {
preloadNext();
Expand Down Expand Up @@ -455,7 +419,6 @@ export function registerEventListeners(sendToWebView: SendToWebView) {
clearStuckTimer();
resetIdle();
active = false;
userPaused = false;
resetRecoveryState();
notifyWebView = null;
};
Expand Down
Loading