Fixed typing error

[jaxoncreed]

Other Test and Linter Fixes:

• Mashlib (Updated linter so test script works SolidOS/mashlib#121)
• Solid-Panes (Fixed linters and tests SolidOS/solid-panes#296)
• Solid-UI (https://github.com/solid/solid-ui/pull/421)
• Rdflib (Fixed typing error #511)

[bourgeoa]

@jaxoncreed
Not sure this change is correct.
You cannot parse json or jsonld if data is not a valid json. A minimal string is "{}".

@jeff-zucker do you have any idea ?

[jaxoncreed]

At least as far as the typings are concerned, options.data is string | undefined, but jsonString is string | undefined | null. All this does is handle the case where jsonString is null.

[jaxoncreed]

@bourgeoa. I looked into it a bit more. options.data is allowed to be undefined as defined here https://github.com/linkeddata/rdflib.js/blob/main/src/fetcher.ts#L187. It's optional, so undefined is allowed. Do you think it shouldn't be optional?

[jeff-zucker]

So it is a question of whether we should let the user create an invalid JSON-LD file. If we say || undefined, we are saying - go ahead create an empty JSON-LD file, you'lll be sorry later, but you asked for it. I we say || {} we are creating something that a later GET with accept=json-ld will not fail on.

[jeff-zucker]

I guess my tendency would be to go ahead and supply the {}.

[jeff-zucker]

The intent of the user's request is "create an empty JSON-LD resource". And BTW I mean jsonString || "{}"; - that will create an empty JSON-LD resource.