Skip to content

Build with Go 1.11#450

Merged
bai merged 1 commit intolinkedin:masterfrom
bai:go111
Dec 10, 2018
Merged

Build with Go 1.11#450
bai merged 1 commit intolinkedin:masterfrom
bai:go111

Conversation

@bai
Copy link
Copy Markdown
Collaborator

@bai bai commented Sep 17, 2018

Since #405 Go 1.11 has been released so this PR switches Go build image to version 1.11 (Alpine 3.8).

Best served with #447.

@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage remained the same at 73.985% when pulling 653fc1a on bai:go111 into 12e681a on linkedin:master.

@coveralls
Copy link
Copy Markdown

coveralls commented Sep 17, 2018

Coverage Status

Coverage remained the same at 73.993% when pulling cb004f9 on bai:go111 into 6f0e490 on linkedin:master.

Copy link
Copy Markdown
Contributor

@vvuibert vvuibert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you also have to update the TRAVIS_GO_VERSION in .travis.yml

Copy link
Copy Markdown

@sam-obeid sam-obeid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bai bai merged commit 3f33e36 into linkedin:master Dec 10, 2018
@bai bai deleted the go111 branch December 10, 2018 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants