ai/live: Add segmented MediaWriter / MediaReader#3705
Conversation
This allows us to stream segments from one in-memory location to another. New reads will always start at the beginning of the current segment. Also make the original MediaWriter follow io.WriteCloser
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3705 +/- ##
===================================================
+ Coverage 31.59467% 31.70296% +0.10829%
===================================================
Files 157 158 +1
Lines 47527 47617 +90
===================================================
+ Hits 15016 15096 +80
- Misses 31617 31626 +9
- Partials 894 895 +1
... and 4 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
| closed bool | ||
| } | ||
|
|
||
| type writerWrapper struct{ mw *MediaWriter } |
There was a problem hiding this comment.
Lgtm, but just curious do we need this struct? It doesn't have any extra functions on top of io.WriteCloser I think?
There was a problem hiding this comment.
Ah yeah, wanted to add a Seq() similar to the reader side but didn't get that in here
This allows us to stream segments from one in-memory location to another. New reads will always start at the beginning of the current segment.
Also make the original MediaWriter follow io.WriteCloser
Needed for #3689