only fire offcanvas click if off canvas is open#333
Merged
tonypaulbarker merged 2 commits into3.xfrom Aug 12, 2025
Merged
Conversation
danchamp
approved these changes
Aug 7, 2025
This was referenced Nov 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #332
What does this change?
At the moment if you click anywhere on the screen on a mobile, it sets the focus to the menu button. This is because we are not checking to only call the close offCanvas function if the offcanvas region is open.
How to test
Visit any microsite page. Reduce the screensize to mobile size. Click somewhere in the body of the page, you'll see they focus goes back to the 'Menu' button.
Checkout this branch, it should be fixed.
How can we measure success?
You can focus inputs on mobile.
Thanks to Big Blue Door for sponsoring my time to work on this.