Open
Conversation
Collaborator
|
Hi @jwertz01, Thanks for the PR but I'd like to preserve the bar plot functionality as it's a less lossy representation of the input data. I'd be more willing to accept this change if you added a separate parameter like CenPlot/cenplot/lib/track/settings.py Line 126 in 6186968 class BarTrackSettings(DefaultTrackSettings):
# ...
start_only: bool = False
"""
Plot start position only. A smoother representation of data.
NOTE: This will result in the last interval's end position being ignored.
"""Then, add a branch here to switch. CenPlot/cenplot/lib/draw/bar.py Lines 48 to 54 in 6186968 if track.options.start_only:
ax.fill_between(
track.data["chrom_st"],
track.data["name"],
0,
label=label,
**plot_options,
)
else:
ax.bar(
track.data["chrom_st"],
track.data["name"],
track.data["chrom_end"] - track.data["chrom_st"],
label=label,
**plot_options,
) |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.