refactor: remove redundant level property from typed logger calls#708
refactor: remove redundant level property from typed logger calls#708kamilwronka wants to merge 1 commit intodevelopfrom
Conversation
When using Winston's `.error()` or `.warn()` methods, the level is
already set by the method itself. Passing `level: "error"` to
`.error()` or `level: "warn"` to `.warn()` is redundant.
Also changed one `.log({ level: "warn" })` call to `.warn()` for
consistency within the same file.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
💤 Files with no reviewable changes (2)
📝 WalkthroughWalkthroughThree service files across activity and API modules have logging calls refactored to remove explicit Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~5 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
level: "error"property fromlogger.error()calls andlevel: "warn"fromlogger.warn()calls across 3 fileslogger.log({ level: "warn" })tologger.warn()for consistency.error(),.warn()) already set the level, making the explicit property a no-opFiles touched
apps/activity/src/activities/services/activities-events.service.ts— 3 redundant level properties removedapps/api/src/kills/kills.service.ts— 2 redundant level properties removedapps/api/src/timers/timers.service.ts— 2 redundant level properties removedWhy this is safe
levelproperty was identical to what the method already sets — removing it produces identical log outputactivities.controller.spec.tsdue to@lootlog/nest-sharedpackage resolution)Residual risks
🤖 Generated with Claude Code
Summary by CodeRabbit