Skip to content

refactor: remove redundant level property from typed logger calls #708

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kamilwronka wants to merge 1 commit into
base: develop
Choose a base branch
from
+1 −8
Open

refactor: remove redundant level property from typed logger calls #708

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions apps/activity/src/activities/services/activities-events.service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,6 @@ export class ActivitiesEventsService {

if (!result.success) {
this.logger.error({
level: "error",
message:
"Invalid activity payload - validation failed (permanent error, sending to DLQ)",
rawPayload: data,
Expand Down Expand Up @@ -94,7 +93,6 @@ export class ActivitiesEventsService {
await this.activitiesService.create(dto);
} catch (error) {
this.logger.error({
level: "error",
message: "Failed to create activity",
error: error instanceof Error ? error.message : String(error),
stack: error instanceof Error ? error.stack : undefined,
Expand All @@ -116,8 +114,7 @@ export class ActivitiesEventsService {
},
})
handleActivityCreateDlq(@RabbitPayload() message: unknown) {
this.logger.log({
level: "warn",
this.logger.warn({
message: "Activity CREATE DLQ message - manual intervention needed",
rawPayload: message,
});
Expand Down
2 changes: 0 additions & 2 deletions apps/api/src/kills/kills.service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,6 @@ export class KillsService {
});
} catch (error) {
this.logger.error({
level: "error",
message: "Failed to upsert user kill stats",
error: error instanceof Error ? error.message : error,
});
Expand Down Expand Up @@ -205,7 +204,6 @@ export class KillsService {
return { guildId, isFirstGuildKill };
} catch (error) {
this.logger.error({
level: "error",
message: `Failed to upsert kill stats for guildId ${guildId}`,
error: error instanceof Error ? error.message : error,
});
Expand Down
2 changes: 0 additions & 2 deletions apps/api/src/timers/timers.service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -281,7 +281,6 @@ export class TimersService implements OnModuleInit {
};
} catch (error) {
this.logger.warn({
level: "warn",
message: "Failed to resolve synthetic timer context for event hero",
guildId,
world,
Expand Down Expand Up @@ -788,7 +787,6 @@ export class TimersService implements OnModuleInit {
})
.catch((error) => {
this.logger.error({
level: "error",
message: "Failed to enqueue event hero kill check",
error: error instanceof Error ? error.message : error,
guildId,
Expand Down
Loading