refactor(gnovm): inline make varg type enforcement, remove isBuiltinMake flag#3
Merged
ltzmaxwell merged 1 commit intoltzmaxwell:fix/maxwell/enforce_varg_typefrom Mar 31, 2026
Conversation
…ake flag Move the int-type enforcement for make's variadic size arguments directly into the `case "make":` special-case block, eliminating the need for the `isBuiltinMake` boolean that coupled the ENTER and LEAVE phases.
ltzmaxwell
approved these changes
Mar 31, 2026
ltzmaxwell
merged commit 57449ea
into
ltzmaxwell:fix/maxwell/enforce_varg_type
7 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move the int-type enforcement for make's variadic size arguments directly into the
case "make":special-case block, eliminating the need for theisBuiltinMakeboolean that coupled the ENTER and LEAVE phases.