Bootloader fixes and support for more NOR flash chips#190
Closed
alex-luxonis wants to merge 21 commits intodevelopfrom
Closed
Bootloader fixes and support for more NOR flash chips#190alex-luxonis wants to merge 21 commits intodevelopfrom
alex-luxonis wants to merge 21 commits intodevelopfrom
Conversation
Contributor
Author
|
TODO: when flashing the bootloader/application, if a bootloader already exists, don't use it to flash, but load first the new bootloader over USB. We may also need to enforce flashing the new bootloader. |
`DEPTHAI_BOOTLOADER_BINARY_USB` `DEPTHAI_BOOTLOADER_BINARY_ETH` (both can be set)
Collaborator
|
Ready for initial re-review |
| bool usage = false, read = true, clear = false; | ||
| std::string path = ""; | ||
| if(argc >= 2) { | ||
| std::string op = argv[1]; |
Contributor
There was a problem hiding this comment.
We can add argparser, looks like this is a copy of the python implementation and header only:
https://github.com/jamolnng/argparse
Collaborator
There was a problem hiding this comment.
Will leave this as a side task to refactor one day. Good suggestion to match Python, thanks 👍
SzabolcsGergely
approved these changes
Aug 23, 2021
Collaborator
|
Merged to #202 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix issues with upgrading bootloader/application with a non-empty flash (due to unaligned erase).
Add back bootloader flash example (was removed previously due to issues).
Add support for more NOR flash chip types used on the 1099/2099 SoMs.
Related PR: luxonis/depthai-bootloader-shared#3
EDIT: